vivkong commented on code in PR #1239: URL: https://github.com/apache/maven/pull/1239#discussion_r1322968946
########## Jenkinsfile.s390x.its: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +pipeline { + agent { node { 's390x' } } + options { + durabilityHint('PERFORMANCE_OPTIMIZED') + buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5')) + timeout(time: 180, unit: 'MINUTES') + } + parameters { + string( defaultValue: 'master', description: 'Core Its branch (default master)', + name: 'ITS_BRANCH' ) Review Comment: Thank you for your review. I used the existing [Jenkinsfile.its](https://github.com/apache/maven/blob/master/Jenkinsfile.its#L28) file as a reference and assumed the parameter is set when the Jenkins build is kicked off (as I cannot access the Jenkins configuration). I don't expect s390x builds to be run with Github actions as there's no s390x support for Github actions at this moment. How does the Jenkins build get triggered with each PR? I cannot find information on this and would appreciate any pointers. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
