vivkong commented on code in PR #1239:
URL: https://github.com/apache/maven/pull/1239#discussion_r1328683017


##########
Jenkinsfile.s390x.its:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+pipeline {
+  agent { node { 's390x' } }
+  options {
+    durabilityHint('PERFORMANCE_OPTIMIZED')
+    buildDiscarder(logRotator(numToKeepStr: '20', artifactNumToKeepStr: '5'))
+    timeout(time: 180, unit: 'MINUTES')
+  }
+  parameters {
+    string( defaultValue: 'master', description: 'Core Its branch (default 
master)',
+            name: 'ITS_BRANCH' )
+  }
+  stages {
+    stage("Build Maven Core") {
+      steps {
+        withEnv(["JAVA_HOME=${ tool "ibm-semeru-8u362-b09" }", 
"PATH+MAVEN=${tool 'Maven 3.6.3'}/bin:${env.JAVA_HOME}/bin"]) {

Review Comment:
   You are right.  I see on the main Jenkinsfile it should be 3.8.x.
   
   We won't need this new `Jenkinsfile.s390x.its` file if s390x builds are run 
nightly or for commits only (no PR checks) (Please see 
https://github.com/apache/maven/pull/1239#issuecomment-1719681339).
   
   If that's ok with you then I can either a) create a new PR or b) reuse this 
PR to reinstate the Jenkinsfile.s390x that was previously removed.  Will need 
help with disabling PR checks in 
https://ci-maven.apache.org/job/Maven/job/Maven%20Core%20s390x/ as I have no 
access to Jenkins configuration.  Please let me know.  Thanks!
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to