AlexanderAshitkin commented on code in PR #92:
URL:
https://github.com/apache/maven-build-cache-extension/pull/92#discussion_r1300186078
##########
src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java:
##########
@@ -129,7 +129,8 @@ public void execute(
boolean restored = result.isSuccess(); // if partially restored
need to save increment
if (restorable) {
restored &= restoreProject(result, mojoExecutions,
mojoExecutionRunner, cacheConfig);
- } else {
+ }
+ if (!restored) {
Review Comment:
That is discussable:
* `clean` phase has been completed by this time, and repeating it sounds
slightly off to me.
* Keeping partially restored artifacts is error-prone, and `clean` might not
even be requested.
* invoking ad-hoc `clean` might wipe out other cached data and might be
undesirable
It is better to leave it as is and rely on the regular `clean`, or implement
`mv` logic to minimize the risk of corrupted cache data in the target dir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
