kbuntrock commented on code in PR #92:
URL: 
https://github.com/apache/maven-build-cache-extension/pull/92#discussion_r1299227649


##########
src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java:
##########
@@ -129,7 +129,8 @@ public void execute(
             boolean restored = result.isSuccess(); // if partially restored 
need to save increment
             if (restorable) {
                 restored &= restoreProject(result, mojoExecutions, 
mojoExecutionRunner, cacheConfig);
-            } else {
+            }
+            if (!restored) {

Review Comment:
   Good idea @maximilian-novikov-db.
   
   @AlexanderAshitkin : do you mean we should change the way we restore 
artefacts from remote caches? I'm more inclined to the "second clean phase" 
idea since it covers any restoration problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to