[
https://issues.apache.org/jira/browse/MSITE-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733672#comment-17733672
]
ASF GitHub Bot commented on MSITE-833:
--------------------------------------
elharo commented on code in PR #155:
URL: https://github.com/apache/maven-site-plugin/pull/155#discussion_r1232855063
##########
src/test/java/org/apache/maven/plugins/site/deploy/SiteDeployMojoTest.java:
##########
@@ -30,14 +30,14 @@
*/
@RunWith(JUnit4.class)
public class SiteDeployMojoTest extends AbstractMojoTestCase {
- private WagonManager wagonManager;
+ private Wagon wagon;
// private Repository repository;
@Before
public void setUp() throws Exception {
super.setUp();
- wagonManager = getContainer().lookup(WagonManager.class);
+ // wagon = getContainer().lookup( Wagon.class, "scp" );
// repository = new Repository( "my-repository",
"scp://repository-host/var/maven2" );
Review Comment:
I respectfully disagree. I would rather see none wrong things and one right
thing than ten wrong things. It is not a good idea to be consistent with
existing bad practice, and you do not have to fix all bad code practices to fix
one thing.
This applies to everything, and in this specific case, commented out code
should not be left in the repo.
> Remove dependency to maven-compat
> ---------------------------------
>
> Key: MSITE-833
> URL: https://issues.apache.org/jira/browse/MSITE-833
> Project: Maven Site Plugin
> Issue Type: Improvement
> Components: Maven 3
> Reporter: Sylwester Lachiewicz
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 4.0.0-M9
>
>
> # Remove usages of the maven-compat classes:
> ## org.apache.maven.artifact.manager.WagonManager
> ## org.apache.maven.artifact.repository.ArtifactRepositoryFactory
> # Move maven-compat scope to test
> [https://cwiki.apache.org/confluence/display/MAVEN/Plugin+migration+to+Maven3+dependencies]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
