[
https://issues.apache.org/jira/browse/MSITE-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733520#comment-17733520
]
ASF GitHub Bot commented on MSITE-833:
--------------------------------------
gnodet commented on code in PR #155:
URL: https://github.com/apache/maven-site-plugin/pull/155#discussion_r1232290987
##########
src/test/java/org/apache/maven/plugins/site/deploy/AbstractSiteDeployWebDavTest.java:
##########
@@ -194,15 +194,10 @@ public void davDeployThruProxyWitAuthzInProxy() throws
Exception {
if
(ReflectionUtils.getFieldByNameIncludingSuperclasses("inputDirectory",
mojo.getClass()) != null) {
setVariableValueToObject(mojo, "inputDirectory",
inputDirectory);
} else {
- ArtifactRepositoryFactory artifactRepositoryFactory =
- getContainer().lookup(ArtifactRepositoryFactory.class);
-
setVariableValueToObject(mojo, "stagingDirectory",
inputDirectory);
setVariableValueToObject(mojo, "reactorProjects",
Collections.emptyList());
setVariableValueToObject(
- mojo,
- "localRepository",
-
artifactRepositoryFactory.createArtifactRepository("local", "foo", "default",
null, null));
+ mojo, "localRepository", new
MavenArtifactRepository("local", "foo", null, null, null));
Review Comment:
Maybe using `MavenRepositorySystem.createArtifactRepository(...)` instead ?
##########
src/test/java/org/apache/maven/plugins/site/deploy/SiteDeployMojoTest.java:
##########
@@ -30,14 +30,14 @@
*/
@RunWith(JUnit4.class)
public class SiteDeployMojoTest extends AbstractMojoTestCase {
- private WagonManager wagonManager;
+ private Wagon wagon;
// private Repository repository;
@Before
public void setUp() throws Exception {
super.setUp();
- wagonManager = getContainer().lookup(WagonManager.class);
+ // wagon = getContainer().lookup( Wagon.class, "scp" );
// repository = new Repository( "my-repository",
"scp://repository-host/var/maven2" );
Review Comment:
Maybe remove before merging if that's not used anymore
> Remove dependency to maven-compat
> ---------------------------------
>
> Key: MSITE-833
> URL: https://issues.apache.org/jira/browse/MSITE-833
> Project: Maven Site Plugin
> Issue Type: Improvement
> Components: Maven 3
> Reporter: Sylwester Lachiewicz
> Assignee: Michael Osipov
> Priority: Major
> Labels: doxia-2.0.0-stack
> Fix For: 4.0.0-M9
>
>
> # Remove usages of the maven-compat classes:
> ## org.apache.maven.artifact.manager.WagonManager
> ## org.apache.maven.artifact.repository.ArtifactRepositoryFactory
> # Move maven-compat scope to test
> [https://cwiki.apache.org/confluence/display/MAVEN/Plugin+migration+to+Maven3+dependencies]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
