[jira] [Commented] (MNG-6825) Cleaning Up dependencies plexus-utils/maven-shared-utils/commons-lang3/commons-io

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709040#comment-17709040
 ] 

ASF GitHub Bot commented on MNG-6825:
-------------------------------------

elharo commented on code in PR #1080:
URL: https://github.com/apache/maven/pull/1080#discussion_r1158836557


##########
maven-core/src/main/java/org/apache/maven/rtinfo/internal/DefaultRuntimeInformation.java:
##########
@@ -90,7 +88,9 @@ private String loadMavenVersion() {
 
     @Override
     public boolean isMavenVersion(String versionRange) {
-        Validate.notBlank(versionRange, "versionRange can neither be null, 
empty nor blank");
+        if (!(versionRange != null && !versionRange.isEmpty())) {
+            throw new IllegalArgumentException("versionRange can neither be 
null nor empty");

Review Comment:
   better to use a NullPointerException for null. The tests below suggest this 
was the existing behavior. 



##########
maven-core/src/main/java/org/apache/maven/rtinfo/internal/DefaultRuntimeInformation.java:
##########
@@ -90,7 +88,9 @@ private String loadMavenVersion() {
 
     @Override
     public boolean isMavenVersion(String versionRange) {
-        Validate.notBlank(versionRange, "versionRange can neither be null, 
empty nor blank");
+        if (!(versionRange != null && !versionRange.isEmpty())) {

Review Comment:
   slightly clearer:
   
   ```
   if (versionRange == null || versionRange.isEmpty())
   ```



##########
maven-artifact/pom.xml:
##########
@@ -30,12 +30,7 @@ under the License.
 
   <name>Maven Artifact</name>
 
-  <dependencies>
-    <dependency>
-      <groupId>org.apache.commons</groupId>
-      <artifactId>commons-lang3</artifactId>
-    </dependency>
-  </dependencies>
+  <dependencies />

Review Comment:
   do we need the empty element or can we just drop it?





> Cleaning Up dependencies 
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> ---------------------------------------------------------------------------------
>
>                 Key: MNG-6825
>                 URL: https://issues.apache.org/jira/browse/MNG-6825
>             Project: Maven
>          Issue Type: Improvement
>          Components: Bootstrap &amp; Build
>    Affects Versions: 3.6.3
>            Reporter: Karl Heinz Marbaise
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>             Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879 
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801 
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562 
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with 
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes 
> commons-io-2.5.jar)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)