[
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709061#comment-17709061
]
ASF GitHub Bot commented on MNG-6825:
-------------------------------------
gnodet commented on code in PR #1080:
URL: https://github.com/apache/maven/pull/1080#discussion_r1158888542
##########
maven-core/src/main/java/org/apache/maven/rtinfo/internal/DefaultRuntimeInformation.java:
##########
@@ -90,7 +88,9 @@ private String loadMavenVersion() {
@Override
public boolean isMavenVersion(String versionRange) {
- Validate.notBlank(versionRange, "versionRange can neither be null,
empty nor blank");
+ if (!(versionRange != null && !versionRange.isEmpty())) {
+ throw new IllegalArgumentException("versionRange can neither be
null nor empty");
Review Comment:
I've always disliked throwing NPE explicitly and this will complicate the
code as the test need to be split... Imho, in all cases, those are illegal
arguments...
I'm going to commit the following:
```
if (Objects.requireNonNull(versionRange, "versionRange cannot be
null").isEmpty()) {
throw new IllegalArgumentException("versionRange cannot be
empty");
}
```
> Cleaning Up dependencies
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> ---------------------------------------------------------------------------------
>
> Key: MNG-6825
> URL: https://issues.apache.org/jira/browse/MNG-6825
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap & Build
> Affects Versions: 3.6.3
> Reporter: Karl Heinz Marbaise
> Assignee: Karl Heinz Marbaise
> Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes
> commons-io-2.5.jar)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
