gnodet commented on code in PR #1079:
URL: https://github.com/apache/maven/pull/1079#discussion_r1158466651
##########
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java:
##########
@@ -70,8 +72,12 @@ private ValidationLevel
validationLevel(RepositorySystemSession session) {
try {
return ValidationLevel.valueOf(level.toUpperCase(Locale.ENGLISH));
} catch (IllegalArgumentException e) {
- throw new IllegalArgumentException(
- "Invalid value specified for property " +
MAVEN_PLUGIN_VALIDATION_KEY + ": '" + level + "'", e);
+ logger.warn(
+ "Invalid value specified for property '{}': '{}'.
Supported values are (case insensitive): {}",
Review Comment:
Ok, that was the exact opposite before this PR. I would assume quotes are
more needed for a user supplied value (which could be empty, with spaces,
etc...) rather than for the property name which we do control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
