slawekjaranowski commented on code in PR #1079: URL: https://github.com/apache/maven/pull/1079#discussion_r1158173224
########## maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java: ########## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.plugin.internal; + +import javax.inject.Named; +import javax.inject.Singleton; + +import java.io.File; +import java.util.Arrays; +import java.util.LinkedHashMap; +import java.util.LinkedHashSet; +import java.util.Locale; +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; + +import org.apache.maven.AbstractMavenLifecycleParticipant; +import org.apache.maven.execution.MavenSession; +import org.apache.maven.model.InputLocation; +import org.apache.maven.plugin.PluginValidationManager; +import org.apache.maven.plugin.descriptor.MojoDescriptor; +import org.apache.maven.plugin.descriptor.PluginDescriptor; +import org.apache.maven.project.MavenProject; +import org.eclipse.aether.RepositorySystemSession; +import org.eclipse.aether.artifact.Artifact; +import org.eclipse.aether.util.ConfigUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +@Singleton +@Named +public final class DefaultPluginValidationManager extends AbstractMavenLifecycleParticipant + implements PluginValidationManager { + + private static final String ISSUES_KEY = DefaultPluginValidationManager.class.getName() + ".issues"; + + private static final String MAVEN_PLUGIN_VALIDATION_KEY = "maven.plugin.validation"; + + private enum ValidationLevel { + DISABLED, + DEFAULT, + VERBOSE + } + + private final Logger logger = LoggerFactory.getLogger(getClass()); + + @Override + public void afterSessionEnd(MavenSession session) { + reportSessionCollectedValidationIssues(session); + } + + private ValidationLevel validationLevel(RepositorySystemSession session) { + String level = ConfigUtils.getString(session, null, MAVEN_PLUGIN_VALIDATION_KEY); + if (level == null || level.isEmpty()) { + return ValidationLevel.DEFAULT; + } + try { + return ValidationLevel.valueOf(level.toUpperCase(Locale.ENGLISH)); + } catch (IllegalArgumentException e) { + logger.warn( + "Invalid value specified for property '{}': '{}'. Supported values are (case insensitive): {}", + MAVEN_PLUGIN_VALIDATION_KEY, + level, + Arrays.toString(ValidationLevel.values())); + return ValidationLevel.DEFAULT; + } + } + + private String pluginKey(String groupId, String artifactId, String version) { + return groupId + ":" + artifactId + ":" + version; + } + + private String pluginKey(MojoDescriptor mojoDescriptor) { + PluginDescriptor pd = mojoDescriptor.getPluginDescriptor(); + return pluginKey(pd.getGroupId(), pd.getArtifactId(), pd.getVersion()); + } + + private String pluginKey(Artifact pluginArtifact) { + return pluginKey(pluginArtifact.getGroupId(), pluginArtifact.getArtifactId(), pluginArtifact.getVersion()); + } + + @Override + public void reportPluginValidationIssue(RepositorySystemSession session, Artifact pluginArtifact, String issue) { + String pluginKey = pluginKey(pluginArtifact); + PluginValidationIssues pluginIssues = + pluginIssues(session).computeIfAbsent(pluginKey, k -> new PluginValidationIssues()); + pluginIssues.reportPluginIssue(null, null, issue); + } + + @Override + public void reportPluginValidationIssue(MavenSession mavenSession, MojoDescriptor mojoDescriptor, String issue) { + String pluginKey = pluginKey(mojoDescriptor); + PluginValidationIssues pluginIssues = pluginIssues(mavenSession.getRepositorySession()) + .computeIfAbsent(pluginKey, k -> new PluginValidationIssues()); + pluginIssues.reportPluginIssue(pluginDeclaration(mojoDescriptor), pluginOccurrence(mavenSession), issue); + } + + @Override + public void reportPluginMojoValidationIssue( + MavenSession mavenSession, MojoDescriptor mojoDescriptor, Class<?> mojoClass, String issue) { + String pluginKey = pluginKey(mojoDescriptor); + PluginValidationIssues pluginIssues = pluginIssues(mavenSession.getRepositorySession()) + .computeIfAbsent(pluginKey, k -> new PluginValidationIssues()); + pluginIssues.reportPluginMojoIssue( + pluginDeclaration(mojoDescriptor), + pluginOccurrence(mavenSession), + mojoInfo(mojoDescriptor, mojoClass), + issue); + } + + private void reportSessionCollectedValidationIssues(MavenSession mavenSession) { + ValidationLevel validationLevel = validationLevel(mavenSession.getRepositorySession()); + ConcurrentHashMap<String, PluginValidationIssues> issuesMap = pluginIssues(mavenSession.getRepositorySession()); + if (!issuesMap.isEmpty()) { + + logger.warn(""); + logger.warn("Plugin validation issues were detected in {} plugin(s)", issuesMap.size()); + logger.warn(""); + if (validationLevel == ValidationLevel.DISABLED || !logger.isWarnEnabled()) { + return; + } Review Comment: If disable nothing should be logged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
