michael-o commented on code in PR #1079:
URL: https://github.com/apache/maven/pull/1079#discussion_r1158199434
##########
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java:
##########
@@ -70,8 +72,12 @@ private ValidationLevel
validationLevel(RepositorySystemSession session) {
try {
return ValidationLevel.valueOf(level.toUpperCase(Locale.ENGLISH));
} catch (IllegalArgumentException e) {
- throw new IllegalArgumentException(
- "Invalid value specified for property " +
MAVEN_PLUGIN_VALIDATION_KEY + ": '" + level + "'", e);
+ logger.warn(
+ "Invalid value specified for property '{}': '{}'.
Supported values are (case insensitive): {}",
Review Comment:
The single quotes aren't necessary after then colon. That's the purpose of
the colon.
##########
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java:
##########
@@ -169,10 +169,10 @@ public void
reportSessionCollectedValidationIssues(MavenSession mavenSession) {
}
logger.warn("");
logger.warn(
- "To fix these issues, please upgrade listed plugins, or
notify their maintainers about these issues.");
+ "To fix these issues, please upgrade above listed plugins,
or, notify their maintainers about reported issues.");
logger.warn("");
logger.warn(
- "To get more or less details, use
'maven.plugin.validation' user property with one of the values: 'disabled',
'verbose' or (implied) 'default'");
+ "For more or less details in this report, use
'maven.plugin.validation' user property with one of the values: 'disabled',
'verbose' or (implied) 'default'");
Review Comment:
description after value:
...'verbose' or 'default' (implied)"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
