[
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702375#comment-17702375
]
ASF GitHub Bot commented on MNG-6825:
-------------------------------------
timtebeek opened a new pull request, #156:
URL: https://github.com/apache/maven-doxia/pull/156
For https://issues.apache.org/jira/browse/MNG-6825
This third PR targets IOUtil, which was not present in apache/maven, hence
I've targeted the project that uses it the most.
Regrettably some manual fixes where needed, as the replacement commons-io
IOUtils does not silently swallow IOExceptions like Plexus IOUtil did. Hence
inlined the old behaviour a couple times and adopted try-with-resources a few
other times.
Not entirely happy both with the process for these replacements and with the
outcomes. PR opened to gather feedback on whether we would want to target the
other replacements similarly, or adopt a different approach, such as more
try-with-resources, or no commons-io IOUtils.
> Cleaning Up dependencies
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> ---------------------------------------------------------------------------------
>
> Key: MNG-6825
> URL: https://issues.apache.org/jira/browse/MNG-6825
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap & Build
> Affects Versions: 3.6.3
> Reporter: Karl Heinz Marbaise
> Assignee: Karl Heinz Marbaise
> Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes
> commons-io-2.5.jar)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
