[ 
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702358#comment-17702358
 ] 

ASF GitHub Bot commented on MNG-6825:
-------------------------------------

gnodet commented on code in PR #1066:
URL: https://github.com/apache/maven/pull/1066#discussion_r1141462604


##########
maven-xml-impl/pom.xml:
##########
@@ -39,12 +39,6 @@ under the License.
       <groupId>org.eclipse.sisu</groupId>
       <artifactId>org.eclipse.sisu.plexus</artifactId>
     </dependency>
-    <dependency>
-      <groupId>org.codehaus.plexus</groupId>
-      <artifactId>plexus-utils</artifactId>

Review Comment:
   Basically, it should not add any new warning when running `mvn 
dependency:analyze` ...





> Cleaning Up dependencies 
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> ---------------------------------------------------------------------------------
>
>                 Key: MNG-6825
>                 URL: https://issues.apache.org/jira/browse/MNG-6825
>             Project: Maven
>          Issue Type: Improvement
>          Components: Bootstrap &amp; Build
>    Affects Versions: 3.6.3
>            Reporter: Karl Heinz Marbaise
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>             Fix For: 4.0.x-candidate
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879 
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801 
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562 
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with 
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes 
> commons-io-2.5.jar)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to