reckart commented on code in PR #82:
URL:
https://github.com/apache/maven-dependency-analyzer/pull/82#discussion_r1140341854
##########
src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java:
##########
@@ -168,20 +174,46 @@ static Set<String> parseConstantPoolClassReferences(
ByteBuffer buf )
break;
}
}
+
Set<String> result = new HashSet<>();
- for ( Integer aClass : classes )
+
+ for ( Integer classRef : classReferences )
{
- String className = stringConstants.get( aClass );
-
- // filter out things from unnamed package, probably a
false-positive
- if ( isImportableClass( className ) )
+ addClassToResult( result, stringConstants.get( classRef ) );
+ }
+
+ for ( Integer typeRef : typeReferences )
+ {
+ String typeName = stringConstants.get( typeRef );
+
+ Type type = Type.getType( typeName );
+ switch ( type.getSort() )
Review Comment:
https://issues.apache.org/jira/browse/MSHARED-1205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
