reckart commented on code in PR #82:
URL:
https://github.com/apache/maven-dependency-analyzer/pull/82#discussion_r1140276325
##########
src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java:
##########
@@ -168,20 +174,46 @@ static Set<String> parseConstantPoolClassReferences(
ByteBuffer buf )
break;
}
}
+
Set<String> result = new HashSet<>();
- for ( Integer aClass : classes )
+
+ for ( Integer classRef : classReferences )
{
- String className = stringConstants.get( aClass );
-
- // filter out things from unnamed package, probably a
false-positive
- if ( isImportableClass( className ) )
+ addClassToResult( result, stringConstants.get( classRef ) );
+ }
+
+ for ( Integer typeRef : typeReferences )
+ {
+ String typeName = stringConstants.get( typeRef );
+
+ Type type = Type.getType( typeName );
+ switch ( type.getSort() )
Review Comment:
Btw. the module doesn't build with Java 19. I have to switch to an older
Java (like 11) before the build so it goes through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
