elharo commented on code in PR #82:
URL:
https://github.com/apache/maven-dependency-analyzer/pull/82#discussion_r1140336852
##########
src/main/java/org/apache/maven/shared/dependency/analyzer/asm/ConstantPoolParser.java:
##########
@@ -168,20 +174,46 @@ static Set<String> parseConstantPoolClassReferences(
ByteBuffer buf )
break;
}
}
+
Set<String> result = new HashSet<>();
- for ( Integer aClass : classes )
+
+ for ( Integer classRef : classReferences )
{
- String className = stringConstants.get( aClass );
-
- // filter out things from unnamed package, probably a
false-positive
- if ( isImportableClass( className ) )
+ addClassToResult( result, stringConstants.get( classRef ) );
+ }
+
+ for ( Integer typeRef : typeReferences )
+ {
+ String typeName = stringConstants.get( typeRef );
+
+ Type type = Type.getType( typeName );
+ switch ( type.getSort() )
Review Comment:
Which module? Do you mean this whole repo? Does this already happen at head,
or is it introduced by this PR?
If it's the case at HEAD, ignore it here and file an issue in the JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
