nielsbasjes commented on code in PR #104:
URL: https://github.com/apache/maven-release/pull/104#discussion_r1133238346


##########
maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java:
##########
@@ -426,6 +426,13 @@
      */
     String getProjectVersionPolicyId();
 
+    /**
+     * Get the (optional) config for the VersionPolicy implementation used to 
calculate the project versions.
+     *
+     * @return The parsed XML of the provided config (an instance of 
XmlPlexusConfiguration) or null.
+     */
+    Object getProjectVersionPolicyConfig();
+

Review Comment:
   I put in the JavaDoc it is really this type. 
   It is the code generated by Modello that dictates to to be `Object`. 
   
   I have tried changing it to `XmlPlexusConfiguration` but the current Modello 
code generator won't let me.
   
   The only way to actually make it an `XmlPlexusConfiguration` is by changing 
(probably) this: 
https://github.com/codehaus-plexus/modello/blob/master/modello-plugins/modello-plugin-java/src/main/java/org/codehaus/modello/plugin/java/JavaModelloGenerator.java#L1368
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to