[GitHub] [maven-release] nielsbasjes commented on a diff in pull request #104: [MRELEASE-1078] Support version policy to read and use SCM tags and commits

[via GitHub]

nielsbasjes commented on code in PR #104:
URL: https://github.com/apache/maven-release/pull/104#discussion_r1133231197


##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptorBuilder.java:
##########
@@ -401,6 +401,18 @@ public ReleaseDescriptorBuilder setProjectVersionPolicyId( 
String projectVersion
         return this;
     }
 
+    /**
+     * <p>setProjectVersionPolicyConfig.</p>
+     *
+     * @param setProjectVersionPolicyConfig a {@link java.lang.String} object
+     * @return a {@link 
org.apache.maven.shared.release.config.ReleaseDescriptorBuilder} object
+     */
+    public ReleaseDescriptorBuilder setProjectVersionPolicyConfig( String 
setProjectVersionPolicyConfig )
+    {
+        releaseDescriptor.setProjectVersionPolicyConfig( 
setProjectVersionPolicyConfig );

Review Comment:
   No, it is an XML. But other than that you can parse it any way you like.
   See for example my current implementation that uses Jackson.
   
https://github.com/nielsbasjes/conventional-commits-maven-release/blob/main/src/main/java/nl/basjes/maven/release/version/conventionalcommits/ConventionalCommitsVersionConfig.java



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org