[GitHub] [maven-compiler-plugin] jorsol commented on a diff in pull request #172: [MCOMPILER-525] - Incremental recompile incorrect detection of dependency change

[via GitHub]

jorsol commented on code in PR #172:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/172#discussion_r1096151839


##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1917,7 +1965,7 @@ private DirectoryScanResult computeInputFileTreeChanges( 
IncrementalBuildHelper
             }
             catch ( IOException e )
             {
-                throw new MojoExecutionException( "Error reading old mojo 
status " + mojoConfigFile, e );
+                throw new UncheckedIOException( "Error reading old mojo status 
" + mojoConfigFile, e );

Review Comment:
   I honestly don't like the current status of that code and there is a lot of 
legacy code that's even deprecated.
   
   I could keep refactoring more and more code and improve it with modern Java, 
but that would require more effort and I already put a lot of time into this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org