[
https://issues.apache.org/jira/browse/MRESOLVER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678788#comment-17678788
]
ASF GitHub Bot commented on MRESOLVER-307:
------------------------------------------
gnodet commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081479002
##########
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##########
@@ -21,13 +21,18 @@
import java.io.File;
import java.util.List;
+import java.util.stream.Stream;
import org.eclipse.aether.artifact.Artifact;
/**
* Manages a repository backed by the IDE workspace, a build session or a
similar ad-hoc collection of artifacts.
+ * <em>Note:</em> Implementors are strongly advised to inherit from {@link
AbstractWorkspaceReader} instead of directly
+ * implementing this interface.
*
* @see org.eclipse.aether.RepositorySystemSession#getWorkspaceReader()
+ * @noimplement This interface is not intended to be implemented by clients.
+ * @noextend This interface is not intended to be extended by clients.
Review Comment:
I _think_ `client` is to be understood in the context of the resolver, i.e.
any piece of software using the resolver. The main client is maven, and it's
the one implementing this interface. This interface is pure SPI and _should be
provided_ by the client.
> Support listing of workspace artifacts
> --------------------------------------
>
> Key: MRESOLVER-307
> URL: https://issues.apache.org/jira/browse/MRESOLVER-307
> Project: Maven Resolver
> Issue Type: Improvement
> Reporter: Christoph Läubrich
> Priority: Major
>
> Currently the WorkspaceReader has a way to list versions or resolve the file
> for an artifact, but there is no way of really get a list of workspace
> artifacts itself.
> The javadoc states:
> {quote}Manages a repository backed by the IDE workspace, a build session or a
> similar ad-hoc collection of artifacts.{quote}
> so the goal is to have a way getting hold of the "collection of artifacts"
> this Workspacereader manages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
