[
https://issues.apache.org/jira/browse/MRESOLVER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678772#comment-17678772
]
ASF GitHub Bot commented on MRESOLVER-307:
------------------------------------------
laeubi commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081454851
##########
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##########
@@ -21,13 +21,18 @@
import java.io.File;
import java.util.List;
+import java.util.stream.Stream;
import org.eclipse.aether.artifact.Artifact;
/**
* Manages a repository backed by the IDE workspace, a build session or a
similar ad-hoc collection of artifacts.
+ * <em>Note:</em> Implementors are strongly advised to inherit from {@link
AbstractWorkspaceReader} instead of directly
+ * implementing this interface.
*
* @see org.eclipse.aether.RepositorySystemSession#getWorkspaceReader()
+ * @noimplement This interface is not intended to be implemented by clients.
+ * @noextend This interface is not intended to be extended by clients.
Review Comment:
See https://github.com/apache/maven-resolver/pull/230#issuecomment-1345642240
> Ideally, I'd make this in 2.0 of resolver, and would introduce "safety
measures" like for the rest: iface directly should not be implemented, but
provide a "support class"?
And here
https://github.com/apache/maven-resolver/pull/230#issuecomment-1345989051
You reference a class that uses
```
@noimplement This interface is not intended to be implemented by clients.
@noextend This interface is not intended to be extended by clients.
```
so maybe I misunderstood?
> Support listing of workspace artifacts
> --------------------------------------
>
> Key: MRESOLVER-307
> URL: https://issues.apache.org/jira/browse/MRESOLVER-307
> Project: Maven Resolver
> Issue Type: Improvement
> Reporter: Christoph Läubrich
> Priority: Major
>
> Currently the WorkspaceReader has a way to list versions or resolve the file
> for an artifact, but there is no way of really get a list of workspace
> artifacts itself.
> The javadoc states:
> {quote}Manages a repository backed by the IDE workspace, a build session or a
> similar ad-hoc collection of artifacts.{quote}
> so the goal is to have a way getting hold of the "collection of artifacts"
> this Workspacereader manages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
