[
https://issues.apache.org/jira/browse/MRESOLVER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678690#comment-17678690
]
ASF GitHub Bot commented on MRESOLVER-307:
------------------------------------------
gnodet commented on code in PR #230:
URL: https://github.com/apache/maven-resolver/pull/230#discussion_r1081249124
##########
maven-resolver-api/src/main/java/org/eclipse/aether/repository/WorkspaceReader.java:
##########
@@ -55,4 +60,11 @@
*/
List<String> findVersions( Artifact artifact );
+ /**
+ * List all available artifacts this workspace repository manages.
+ *
+ * @return a stream of artifacts in no particular order
+ */
+ Stream<Artifact> listArtifacts();
Review Comment:
> After reconsidering this change, I am -1 on it (now or 2.x), reasons:
>
> * I see no point of adding new methods to resolver interface that resolver
itself is NOT going to use
> * obviously, these methods are needed to some "integrator" of resolver,
but as can be seen on example of Maven (as one of integrator), one can
introduces specific reader (in maven it is MavenWorkspaceReader) and decorate
it by adding specific methods to it
> * also,by adding methods here we would force any other integrator to
implement them even if they would not need it (as resolver itself is not using
these either).
@laeubi why do you need this additional method if you will the eclipse
integration provides both the implementation and the caller ? I fail to
understand the benefit here...
> Support listing of workspace artifacts
> --------------------------------------
>
> Key: MRESOLVER-307
> URL: https://issues.apache.org/jira/browse/MRESOLVER-307
> Project: Maven Resolver
> Issue Type: Improvement
> Reporter: Christoph Läubrich
> Priority: Major
>
> Currently the WorkspaceReader has a way to list versions or resolve the file
> for an artifact, but there is no way of really get a list of workspace
> artifacts itself.
> The javadoc states:
> {quote}Manages a repository backed by the IDE workspace, a build session or a
> similar ad-hoc collection of artifacts.{quote}
> so the goal is to have a way getting hold of the "collection of artifacts"
> this Workspacereader manages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
