[
https://issues.apache.org/jira/browse/MNG-7630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678562#comment-17678562
]
ASF GitHub Bot commented on MNG-7630:
-------------------------------------
cstamas commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1080950099
##########
maven-core/src/main/java/org/apache/maven/internal/aether/MavenChainedWorkspaceReader.java:
##########
@@ -60,6 +62,31 @@ public Model findModel(Artifact artifact) {
return null;
}
+ @Override
+ public Stream<Artifact> listArtifacts() {
+ return Arrays.stream(readers)
+ .flatMap(r -> {
+ // TODO once resolver 2.x is there this part can be
simplified
+ if (r instanceof MavenWorkspaceReader) {
+ return ((MavenWorkspaceReader) r).listArtifacts();
+ }
+ return Stream.empty();
Review Comment:
personally I prefer if-else, reading code similar to this requires more
attention IMHO and is easy to slip on it
> Support listing of workspace models and implement upcomming interface methods
> -----------------------------------------------------------------------------
>
> Key: MNG-7630
> URL: https://issues.apache.org/jira/browse/MNG-7630
> Project: Maven
> Issue Type: Improvement
> Reporter: Christoph Läubrich
> Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> This is the Maven counterpart of MRESOLVER-307.
> As this will be most likely be released in resolver 2.0 only maven can still
> already have an implementation for the new methods to:
> - show how they would look like
> - if upgrading source is already prepared
> - Maven has an own extension of that interface that should have similar
> behaviour
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
