[
https://issues.apache.org/jira/browse/MNG-7630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678663#comment-17678663
]
ASF GitHub Bot commented on MNG-7630:
-------------------------------------
laeubi commented on code in PR #913:
URL: https://github.com/apache/maven/pull/913#discussion_r1081186329
##########
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenWorkspaceReader.java:
##########
@@ -28,4 +29,20 @@
public interface MavenWorkspaceReader extends WorkspaceReader {
Model findModel(Artifact artifact);
+
+ /**
+ * List all available artifacts this workspace repository manages.
+ *
+ * @return a stream of artifacts in no particular order
+ * @since 3.9.0
+ */
+ Stream<Artifact> listArtifacts();
Review Comment:
[From the
javadoc](https://docs.oracle.com/javase/8/docs/api/java/util/stream/Stream.html):
> Streams have a
[BaseStream.close()](https://docs.oracle.com/javase/8/docs/api/java/util/stream/BaseStream.html#close--)
method and implement
[AutoCloseable](https://docs.oracle.com/javase/8/docs/api/java/lang/AutoCloseable.html),
**but nearly all stream instances do not actually need to be closed after
use**. Generally, only streams whose source is an IO channel (such as those
returned by [Files.lines(Path,
Charset)](https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#lines-java.nio.file.Path-java.nio.charset.Charset-))
will require closing. Most streams are backed by collections, arrays, or
generating functions, which require no special resource management.
as there is no IO involved, there is no problem and callers can convert to
list if they think it is required.
> Support listing of workspace models and implement upcomming interface methods
> -----------------------------------------------------------------------------
>
> Key: MNG-7630
> URL: https://issues.apache.org/jira/browse/MNG-7630
> Project: Maven
> Issue Type: Improvement
> Reporter: Christoph Läubrich
> Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> This is the Maven counterpart of MRESOLVER-307.
> As this will be most likely be released in resolver 2.0 only maven can still
> already have an implementation for the new methods to:
> - show how they would look like
> - if upgrading source is already prepared
> - Maven has an own extension of that interface that should have similar
> behaviour
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
