[ 
https://issues.apache.org/jira/browse/MNG-7630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678528#comment-17678528
 ] 

ASF GitHub Bot commented on MNG-7630:
-------------------------------------

cstamas commented on PR #913:
URL: https://github.com/apache/maven/pull/913#issuecomment-1396560239

   Am fine with this go into 3.9 and not impose any change in resolver, and 
here is why:
   * there is already this MavenWorkspaceReader that already extends resolver 
WorkspaceReader by adding "maven specific" calls onto it.
   * Resolver workspace reader has all of its requirements fulfilled with 
existing WorkspaceReader interface, so adding methods there ONLY to fulfill 
some 3rd party (integrating) library is a no go for me (and just like Maven, 
3rd party user can extend WorkspaceReader to suit its own needs)
   * hence, doing this or similar change on resolver WorkspaceReader is IMHO no 
go and not needed, OTOH, this change here (in "maven realm") is completely OK 
to me




> Support listing of workspace models and implement upcomming interface methods
> -----------------------------------------------------------------------------
>
>                 Key: MNG-7630
>                 URL: https://issues.apache.org/jira/browse/MNG-7630
>             Project: Maven
>          Issue Type: Improvement
>            Reporter: Christoph Läubrich
>            Priority: Major
>
> This is the Maven counterpart of MRESOLVER-307.
> As this will be most likely be released in resolver 2.0  only maven can still 
> already have an implementation for the new methods to:
> - show how they would look like
> - if upgrading source is already prepared
> - Maven has an own extension of that interface that should have similar 
> behaviour



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to