[GitHub] [maven-wrapper] bmarwell commented on a diff in pull request #61: Switch to JUnit Jupiter

[GitBox]

bmarwell commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1060158379


##########
maven-wrapper/src/test/java/org/apache/maven/wrapper/WrapperExecutorTest.java:
##########
@@ -222,27 +226,27 @@ public void 
testEnvironmentVariableOverwrite_mvnwRepoUrl_trailingSlash()
 
     WrapperExecutor wrapper = 
prepareWrapperExecutorWithEnvironmentVariables(environmentVariables);
 
-    Assert.assertEquals( "https://repo/test/path/to/bin.zip";, 
wrapper.getDistribution().toString() );
+    assertEquals( "https://repo/test/path/to/bin.zip";, 
wrapper.getDistribution().toString() );
   }
 
   @Test
-  public void testEnvironmentVariableOverwrite_packageName()
-          throws Exception
+  void testEnvironmentVariableOverwrite_packageName()
+    throws Exception
   {
     final Map<String, String> environmentVariables = new HashMap<>();
     environmentVariables.put( MVNW_REPOURL, "https://repo/test"; );
     properties = new Properties();
-    properties.put( "distributionUrl", 
"https://server/org/apache/maven/to/bin.zip"; );
-    writePropertiesFile( properties, propertiesFile, "header" );
+    properties.put("distributionUrl", 
"https://server/org/apache/maven/to/bin.zip";);
+    writePropertiesFile(properties, propertiesFile, "header");

Review Comment:
   Style: you removed whitespace after the opening parenthesis 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org