timtebeek commented on code in PR #61:
URL: https://github.com/apache/maven-wrapper/pull/61#discussion_r1059926539
##########
maven-wrapper/pom.xml:
##########
@@ -33,27 +33,43 @@ under the License.
<name>Maven Wrapper Jar</name>
<description>Maven Wrapper Jar download, installs and launches installed
target Maven distribution as part of Maven Wrapper scripts run.</description>
+ <properties>
+ <junit.version>5.9.1</junit.version>
+ <mockito.version>4.11.0</mockito.version>
+ </properties>
+
<dependencies>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.13.2</version>
- <scope>test</scope>
- </dependency>
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-core</artifactId>
<version>2.2</version>
Review Comment:
No property here as hamcrest was last released in 2019, and is unlikely to
change in the future. Might want to swap Hamcrest for AssertJ, as it's only in
two test classes. Suggest to tackle that separately from this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
