cstamas commented on code in PR #197: URL: https://github.com/apache/maven-resolver/pull/197#discussion_r975752242
########## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/filter/RemoteRepositoryFilterSourceSupport.java: ########## @@ -0,0 +1,160 @@ +package org.eclipse.aether.internal.impl.filter; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.nio.file.Paths; + +import org.eclipse.aether.RepositorySystemSession; +import org.eclipse.aether.spi.connector.filter.RemoteRepositoryFilter; +import org.eclipse.aether.spi.connector.filter.RemoteRepositoryFilterSource; +import org.eclipse.aether.util.ConfigUtils; + +import static java.util.Objects.requireNonNull; + +/** + * Remote repository filter source filtering on G coordinate. It is backed by a file that lists all allowed groupIds + * and groupId not present in this file is filtered out. The file can be authored manually (groupId per line) or + * by this filter by "record" function. When "recording", this filter will not filter out anything, but will instead + * populate the file will all groupIds it was requested about. + * + * @since TBD + */ +public abstract class RemoteRepositoryFilterSourceSupport + implements RemoteRepositoryFilterSource +{ + private static final String CONFIG_PROP_PREFIX = "aether.remoteRepositoryFilter."; + + private static final String CONF_NAME_ENABLED = "enabled"; + + private static final String CONF_NAME_INSTANCE = "instance"; + + private final String id; + + private final String description; + + protected RemoteRepositoryFilterSourceSupport( String id, String description ) + { + this.id = requireNonNull( id ); + this.description = requireNonNull( description ); + } + + @Override + public String getId() + { + return id; + } + + @Override + public String getDescription() + { + return description; + } + + @Override + public RemoteRepositoryFilter getRemoteRepositoryFilter( RepositorySystemSession session ) + { + boolean enabled = ConfigUtils.getBoolean( session, false, configPropKey( CONF_NAME_ENABLED ) ); + if ( !enabled ) + { + return null; + } + return (RemoteRepositoryFilter) session.getData().computeIfAbsent( configPropKey( CONF_NAME_INSTANCE ), () -> Review Comment: This is unneeded, mgr caches managed instace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
