cstamas commented on code in PR #197:
URL: https://github.com/apache/maven-resolver/pull/197#discussion_r990616904
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultArtifactResolver.java:
##########
@@ -282,10 +297,31 @@ private List<ArtifactResult> resolve(
RepositorySystemSession session,
continue;
}
+ List<RemoteRepository> remoteRepositories =
request.getRepositories();
+ List<RemoteRepository> filteredRemoteRepositories = new
ArrayList<>( remoteRepositories.size() );
+ for ( RemoteRepository repository : remoteRepositories )
+ {
+ RemoteRepositoryFilter.Result filterResult =
filter.acceptArtifact( repository, artifact );
+ if ( !filterResult.isAccepted() )
+ {
+ result.addException( new ArtifactNotFoundException(
artifact, repository,
+ filterResult.reasoning() ) );
+ }
+ else
+ {
+ filteredRemoteRepositories.add( repository );
+ }
+ }
+
+ final boolean remoteConsidered = !remoteRepositories.isEmpty();
+ final boolean filteringApplied = remoteConsidered
+ && !remoteRepositories.equals( filteredRemoteRepositories
);
Review Comment:
Yes, see here
https://github.com/apache/maven-resolver/blob/master/maven-resolver-api/src/main/java/org/eclipse/aether/repository/RemoteRepository.java#L265-L300
(and it is a `final` class on purpose as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
