[
https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603949#comment-17603949
]
ASF GitHub Bot commented on MNGSITE-491:
----------------------------------------
olamy commented on PR #321:
URL: https://github.com/apache/maven-site/pull/321#issuecomment-1246399796
> > > This is problematic because three days is not much, especially when
there is weekend, public holidays, etc. Consider also that Pr can be complex
which means they require some significant amount of time to understand and
evaluate. For me personally, three days is nothing.
> >
> >
> > You can always put a comment that you want to do review and need more
time, add yourself as reviewer ... of course if you not absent
>
> In that case, you can review (and push back) after the commit. I feel that
72h are a courtesy by every committer to allow review. But in reality, a
committer has the _right_ to commit to the code base without seeking additional
approvals or permission or require review. That is the Apache way. Asking the
committers very nicely (or write it down) to give a 72h hour review period
before merging is perfectly acceptable. Requiring non-Apache tools is not.
>
> There is nothing wrong with committing directly to gitbox.
https://infra.apache.org/apache-github.html claims that it is a dual-master
sync setup.
well we can always imagine committers pushing a branch to gitbox if they
don't want to use gitbox (tbh we are in 2022 now and not sure this still
happen) but why not or providing a patch file attached in a jira (I feel like
going back 10 years backward :) ). this has already been mentioned in the
discussion here.
But if this happen I don't mind creating a PR from this branch or this patch
(as there is a low chance about this happening).
btw the created branch in gitbox will generate a CI build in Jenkins and the
branch will be sync to github so from there it's easy to create a PR.
but sure I understand the fact people may not want to create a github
account for privacy reason.
> Update commit policy related documents to avoid any misunderstanding
> --------------------------------------------------------------------
>
> Key: MNGSITE-491
> URL: https://issues.apache.org/jira/browse/MNGSITE-491
> Project: Maven Project Web Site
> Issue Type: Improvement
> Reporter: Tamás Cservenák
> Priority: Major
>
> Last update related to commit policies happened while project was still
> hosted in Subversion. Since then, a LOT of that changed (migrated to git,
> using Github.com, etc), so refresh the parts that are dated since Svn and are
> related to commit policies.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
