[ 
https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603513#comment-17603513
 ] 

ASF GitHub Bot commented on MNGSITE-491:
----------------------------------------

stephenc commented on PR #321:
URL: https://github.com/apache/maven-site/pull/321#issuecomment-1245246427

   > CI build pass (some flakyness can be admitted due to overloading of some 
CI)
   
   There are also cases where you need to make some changes that risk breaking 
the CI job itself such that a passing CI is impossible... think changes that 
affect the CI process itself... a change to the build process on the master 
branch may only be fully testable when it has been merged... and some changes 
invoke the "trusted branch" effect such that they cannot be verified on a PR...
   
   Modulo those exceptions I think a passing CI is a requirement... but I would 
word it as:
   
   * A passing CI build... or a valid documented reason why the CI build cannot 
be made to pass and in that case you no longer get to merge without at least 
one approval




> Update commit policy related documents to avoid any misunderstanding
> --------------------------------------------------------------------
>
>                 Key: MNGSITE-491
>                 URL: https://issues.apache.org/jira/browse/MNGSITE-491
>             Project: Maven Project Web Site
>          Issue Type: Improvement
>            Reporter: Tamás Cservenák
>            Priority: Major
>
> Last update related to commit policies happened while project was still 
> hosted in Subversion. Since then, a LOT of that changed (migrated to git, 
> using Github.com, etc), so refresh the parts that are dated since Svn and are 
> related to commit policies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to