[ https://issues.apache.org/jira/browse/MNGSITE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603775#comment-17603775 ]
ASF GitHub Bot commented on MNGSITE-491: ---------------------------------------- olamy commented on PR #321: URL: https://github.com/apache/maven-site/pull/321#issuecomment-1245965165 > > This is problematic because three days is not much, especially when there is weekend, public holidays, etc. Consider also that Pr can be complex which means they require some significant amount of time to understand and evaluate. For me personally, three days is nothing. > > You can always put a comment that you want to do review and need more time, add yourself as reviewer ... of course if you not absent > > But I agree that standard 72H should be enough for first contact. > > > Merged commit/squash/rebase must contain a reference to the PR > > If we will do PR on GitHub, reference to PR are saved in commit, can be accessible by GUI or api > > ``` > gh api /repos/apache/maven/commits/750e1e3/pulls --jq '.[].html_url' > https://github.com/apache/maven/pull/792 > ``` Ok. but not sure we really need some complicated script ;) if some wants why not. but perso I merge using GH UI or `gh` cli tool. It's simple/just doing the job/ezy/convenient/etc... :) > Update commit policy related documents to avoid any misunderstanding > -------------------------------------------------------------------- > > Key: MNGSITE-491 > URL: https://issues.apache.org/jira/browse/MNGSITE-491 > Project: Maven Project Web Site > Issue Type: Improvement > Reporter: Tamás Cservenák > Priority: Major > > Last update related to commit policies happened while project was still > hosted in Subversion. Since then, a LOT of that changed (migrated to git, > using Github.com, etc), so refresh the parts that are dated since Svn and are > related to commit policies. -- This message was sent by Atlassian Jira (v8.20.10#820010)