michael-o commented on code in PR #757:
URL: https://github.com/apache/maven/pull/757#discussion_r901018896
##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java:
##########
@@ -176,18 +176,31 @@ public MojoDescriptor getMojoDescriptor( String task,
MavenSession session, Mave
}
else if ( numTokens == 3 )
{
- // We have everything that we need except the version
- //
- //
org.apache.maven.plugins:maven-remote-resources-plugin:???:process
- //
- // groupId
- // artifactId
- // ???
- // goal
- //
- plugin = new Plugin();
- plugin.setGroupId( tok.nextToken() );
- plugin.setArtifactId( tok.nextToken() );
+ // groupId:artifactId:goal or pluginPrefix:version:goal (since
Maven 3.9)
+
+ String firstToken = tok.nextToken();
+ // groupId or pluginPrefix? heuristics: groupId contains . but not
pluginPrefix
+ if ( firstToken.contains( "." ) )
Review Comment:
I don't think we can make this assumption for sure since for testing or
other reasong the groupId could be: `foo`, `bar-baz`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
