hboutemy commented on code in PR #757:
URL: https://github.com/apache/maven/pull/757#discussion_r901430691
##########
maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java:
##########
@@ -176,18 +176,31 @@ public MojoDescriptor getMojoDescriptor( String task,
MavenSession session, Mave
}
else if ( numTokens == 3 )
{
- // We have everything that we need except the version
- //
- //
org.apache.maven.plugins:maven-remote-resources-plugin:???:process
- //
- // groupId
- // artifactId
- // ???
- // goal
- //
- plugin = new Plugin();
- plugin.setGroupId( tok.nextToken() );
- plugin.setArtifactId( tok.nextToken() );
+ // groupId:artifactId:goal or pluginPrefix:version:goal (since
Maven 3.9)
+
+ String firstToken = tok.nextToken();
+ // groupId or pluginPrefix? heuristics: groupId contains . but not
pluginPrefix
+ if ( firstToken.contains( "." ) )
Review Comment:
if you want to test a plugin for such simplified run, just don't define such
a groupId
at least, it seems to work for real world plugins, that's the first intent
of course, if you find a better heuristics, or even an algorithm, I'm all
ears open
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
