stevecrox commented on PR #34: URL: https://github.com/apache/maven-fluido-skin/pull/34#issuecomment-1153301311
Pretty happy with how breadcrumbs, project version, and sidebar now look. This layout should translate across all versions of bootstrap. Resolves certain spacing issues causing some of the IT examples to have layout issues. I am happy with the topbar design its compatible with Bootstrap 3 -> 5, breadcrumb has a hardcoded background colour in 3 which is frustrating but looks that is fixed in 4 and I've laid this out to once we are on 5 it will just work. Submenu's from the topbar are still broken, need a bit more time to investigate. Prettify was broken, through sheer luck I've located the original Google Library and the only release in NPM Registry. Using this seems to have restored prettify but its listing line numbers in blocks of 5, probably some configuration option I need to figure out. mskins24_topbar seems to be the only IT layout which is broken, will go on the list -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
