stevecrox commented on PR #34:
URL: https://github.com/apache/maven-fluido-skin/pull/34#issuecomment-1149203453

   While it should now build, it looks like Bootstrap 2 -> 3 dropped some 
classes and I have some more macro rework to do.
   
   I think I am going to have to split the topbar/sidebar macros, the current 
approach takes advantage of Bootstrap 2 css, it wasn't how you were supposed to 
lay them out but it rendered correctly. Bootstrap 5 pushes a fairly defined 
Header/Main/Footer layout, which is possible in 3 which seems a baby step 
forwards.
   
   I'll work on it more tomorrow


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to