stevecrox commented on PR #34: URL: https://github.com/apache/maven-fluido-skin/pull/34#issuecomment-1152765601
Making progress, the breadcrumb section has been pulled into the nav along with a few other bits since we want it embedded along with it. This has lead to some movement around the template. I'm also using the elements to generate the effect I want, for example all buttons/menus are within the navbar-collpase so they should shrink behind a hamburger menu cleanly. The submenu behavoir has broken (it looks fine, will investigate soon). mskins-24_topbar is my current focus because something really odd is happening in the construction and I need to understand that. There have been a few CSS class updates. I've been moving between mskins-10 and topbar, I'm pretty happy with topbar atm. mskins-10 sidebar is the next challenge. The use of Nav-items in it and the topbar causes a conflict in padding/margins. I need to figure out an approach which works with the recommended bootstrap styles. I have been using Bootstrap 3.3 and Bootstrap 5 examples, there is a clear evolution from 3 -> 5 and the structure of 3 seems to be compatible with 5 (and vice verse) so I figure from a technical debt perspective the closer I can get the easier for long term upgrades - https://getbootstrap.com/docs/3.3/examples/navbar-fixed-top/ - https://getbootstrap.com/docs/5.0/examples/navbar-fixed/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
