[
https://issues.apache.org/jira/browse/MRESOLVER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552164#comment-17552164
]
ASF GitHub Bot commented on MRESOLVER-262:
------------------------------------------
grgrzybek commented on PR #182:
URL: https://github.com/apache/maven-resolver/pull/182#issuecomment-1151034135
New version of tracking extension:
https://github.com/grgrzybek/tracking-maven-extension/commits/resolver-1.8.x
I've performed these tests building
https://github.com/ops4j/org.ops4j.pax.web project:
* Maven 3.8.6 with maven-resolver 1.8.1-SNAPSHOT with this #182 merged and
`-Dmaven.ext.class.path` pointing to my extension
* Maven 3.8.6 with maven-resolver 1.8.1-SNAPSHOT with this #182 merged
without my extension
* Maven 3.8.6 with maven-resolver 1.8.1-SNAPSHOT with this #182 merged and
`-Dmaven.ext.class.path` pointing to my extension and with
`-Daether.collector.impl=bf`
* Maven 3.8.6 with maven-resolver 1.8.1-SNAPSHOT with this #182 merged
without my extension and with `-Daether.collector.impl=bf`
* Maven 3.8.5 with normal maven-resolver 1.6.3
and then 2nd time each of the above again on previously populated repo. Here
are the results (tme = [tracking maven
extension](https://github.com/grgrzybek/tracking-maven-extension/commits/resolver-1.8.x
)):
| | fresh repository | existing repository |
|---|---|---|
|mvn 3.8.6 + resolver 1.8.1 + #182 + tme + DF|5:25 min|1:08 min|
|mvn 3.8.6 + resolver 1.8.1 + #182 + DF|5:09 min|1:07 min|
|mvn 3.8.6 + resolver 1.8.1 + #182 + tme + BF|5:15 min|1:07 min|
|mvn 3.8.6 + resolver 1.8.1 + #182 + BF|5:04 min|1:07 min|
|mvn 3.8.5 + resolver 1.6.3|5:19 min|1:07 min|
It's too small sample to treat it as proper performance test, but it can be
a rough estimate.
When nothing is downloaded (already populated repo) the times are almost the
same.
* When downloading is involved the extension's listener (where all the
`.tracking` content is created) adds 10-15 seconds to the processing (~4-5%).
* BF is slightly faster than DF.
There are small difference between BF and DF when checking the reversed
dependency trees - these are fully expected and actually show the difference in
graph navigation. For example for aopalliance:aopalliance:1.0 I had:
DF:
```
aopalliance:aopalliance:pom:1.0
aopalliance:aopalliance:jar:1.0 (compile) (plugin)
org.sonatype.sisu:sisu-guice:jar:no_aop:3.1.0 (compile) (plugin)
org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.0.0.M5 (compile)
(plugin)
org.apache.maven:maven-plugin-api:jar:3.1.1 (compile) (plugin)
org.apache.maven.enforcer:enforcer-api:jar:3.0.0 (compile) (plugin)
org.commonjava.maven.enforcer:enforce-managed-deps-rule:jar:1.3
(runtime) (plugin)
org.apache.maven.plugins:maven-enforcer-plugin:jar:3.0.0 ()
(plugin)
Repository: central (https://repo.maven.apache.org/maven2, default, releases)
```
BF:
```
aopalliance:aopalliance:pom:1.0
aopalliance:aopalliance:jar:1.0 (compile) (plugin)
org.sonatype.sisu:sisu-guice:jar:no_aop:3.1.0 (compile) (plugin)
org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.0.0.M5 (compile)
(plugin)
org.apache.maven:maven-plugin-api:jar:3.1.1 (compile) (plugin)
org.apache.maven.plugins:maven-enforcer-plugin:jar:3.0.0 ()
(plugin)
Repository: central (https://repo.maven.apache.org/maven2, default, releases)
```
I'm going to have a look now at the plugins I've mentioned earlier
(org.apache.camel.springboot:camel-spring-boot-generator-maven-plugin and
org.apache.karaf.tooling:karaf-maven-plugin).
Summarizing - the resolver changes are great! thanks @cstamas ! (cc: @gnodet
)
> Provide contextual data in trace data for collector invoked requests
> --------------------------------------------------------------------
>
> Key: MRESOLVER-262
> URL: https://issues.apache.org/jira/browse/MRESOLVER-262
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
> Reporter: Tamás Cservenák
> Priority: Major
> Fix For: 1.8.1
>
>
> During collection several RepositoryEvents are fired, but they does not carry
> any context related data regarding artifact collection.
> Simplest solution would be to extend RequestTrace to provide:
> * request context
> * the artifact path (from root to leaf)
> * leaf artifact being collected
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
