[ https://issues.apache.org/jira/browse/DOXIA-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545496#comment-17545496 ]
ASF GitHub Bot commented on DOXIA-590: -------------------------------------- feckertson commented on PR #104: URL: https://github.com/apache/maven-doxia/pull/104#issuecomment-1144929969 Apologies for not checking the diff before creating the PR. The apache format introduced unintended changes/noise. The standard format should be applied, but in a PR which only does that. I couldn't find standard eclipse settings (code cleanup) for this org/project to avoid the diamond changes? Are there any? > Either provided element class or default class gets ignored > ----------------------------------------------------------- > > Key: DOXIA-590 > URL: https://issues.apache.org/jira/browse/DOXIA-590 > Project: Maven Doxia > Issue Type: Bug > Components: Core > Affects Versions: 1.8 > Reporter: Fred Eckertson > Assignee: Michael Osipov > Priority: Major > Fix For: 2.0.0-M3, 1.11.2 > > Attachments: image-2022-05-18-21-57-40-619.png > > > The following construct is somewhat common in doxia-core > att.addAttribute( Attribute.CLASS, "a" ); > The documentation says that basic attributes (including CLASS) are supported. > However in cases like this either that "a" or the CLASS that was provided in > the attributes parameter will be ignored. The correct way to do this is to > append the provided CLASS to "a " if a CLASS attribute was provided. -- This message was sent by Atlassian Jira (v8.20.7#820007)