[ 
https://issues.apache.org/jira/browse/DOXIA-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17545258#comment-17545258
 ] 

ASF GitHub Bot commented on DOXIA-590:
--------------------------------------

feckertson commented on PR #98:
URL: https://github.com/apache/maven-doxia/pull/98#issuecomment-1144396324

   @michael-o PR #104 improves this PR to allow the `hidden` class to decide 
whether the even/odd row parity gets toggled which is the gist of the matter.  
If one wants ternary+ coloring, one can override the `a` and `b` css to do 
nothing and define/manage alternate classes based on visible row number mod N. 
   
   Ideally org.apache.maven.skins:maven-skins should be improved to hide the 
'hidden' rows, but one can provide additional css to do that in the meantime.




> Either provided element class or default class gets ignored
> -----------------------------------------------------------
>
>                 Key: DOXIA-590
>                 URL: https://issues.apache.org/jira/browse/DOXIA-590
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.8
>            Reporter: Fred Eckertson
>            Assignee: Michael Osipov
>            Priority: Major
>             Fix For: 2.0.0-M3, 1.11.2
>
>         Attachments: image-2022-05-18-21-57-40-619.png
>
>
> The following construct is somewhat common in doxia-core
> att.addAttribute( Attribute.CLASS, "a" );
> The documentation says that basic attributes (including CLASS) are supported. 
> However in cases like this either that "a" or the CLASS that was provided in 
> the attributes parameter will be ignored. The correct way to do this is to 
> append the provided CLASS to "a " if a CLASS attribute was provided.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to