[
https://issues.apache.org/jira/browse/MSKINS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17532470#comment-17532470
] Konrad Windszus edited comment on MSKINS-170 at 5/5/22 6:18 PM: ---------------------------------------------------------------- The h2 is actually coming from macro `banner` with a banner object not containing a `src` property: https://github.com/apache/maven-fluido-skin/blob/7e92f9bb3c6efffb99c3708444957e153c55dd37/src/main/resources/META-INF/maven/site-macros.vm#L182 So it seems there are two different fallbacks here: a) for a site definition not containing a `bannerLeft` (https://github.com/apache/maven-fluido-skin/blob/7e92f9bb3c6efffb99c3708444957e153c55dd37/src/main/resources/META-INF/maven/site.vm#L191) b) for a site definition containing a `bannerLeft` without `src` ( (https://github.com/apache/maven-fluido-skin/blob/7e92f9bb3c6efffb99c3708444957e153c55dd37/src/main/resources/META-INF/maven/site.vm#L189 and https://github.com/apache/maven-fluido-skin/blob/7e92f9bb3c6efffb99c3708444957e153c55dd37/src/main/resources/META-INF/maven/site-macros.vm#L182 (https://maven.apache.org/doxia/doxia-sitetools/doxia-decoration-model/decoration.html#class_bannerLeft) In the case of https://sling.apache.org/components/scriptingbundle-maven-plugin-archives/scriptingbundle-maven-plugin-0.3.0/ the site.xml looks like https://github.com/apache/sling-scriptingbundle-maven-plugin/blob/scriptingbundle-maven-plugin-0.3.0/src/site/site.xml (and inherits from ASF Parent 23 through https://github.com/apache/sling-parent/blob/sling-parent-reactor-41/sling-parent/pom.xml which doesn't contain any site.xml), so it is unclear to me why we run into fallback b) instead of a). [~hboutemy] Any idea since you implemented both fallbacks? was (Author: kwin): The h2 is actually coming from macro `banner` with a banner object not containing a `src` property: https://github.com/apache/maven-fluido-skin/blob/7e92f9bb3c6efffb99c3708444957e153c55dd37/src/main/resources/META-INF/maven/site-macros.vm#L182 So it seems there are two different fallbacks here: a) for a site definition not containing a `bannerLeft` (https://github.com/apache/maven-fluido-skin/blob/7e92f9bb3c6efffb99c3708444957e153c55dd37/src/main/resources/META-INF/maven/site.vm#L189) b) for a site definition containing a `bannerLeft` without `src` (https://maven.apache.org/doxia/doxia-sitetools/doxia-decoration-model/decoration.html#class_bannerLeft) In the case of https://sling.apache.org/components/scriptingbundle-maven-plugin-archives/scriptingbundle-maven-plugin-0.3.0/ the site.xml looks like https://github.com/apache/sling-scriptingbundle-maven-plugin/blob/scriptingbundle-maven-plugin-0.3.0/src/site/site.xml (and inherits from ASF Parent 23 through https://github.com/apache/sling-parent/blob/sling-parent-reactor-41/sling-parent/pom.xml which doesn't contain any site.xml), so it is unclear to me why we run into fallback b) instead of a). [~hboutemy] Any idea since you implemented both fallbacks? > Allow to show name as headline in addition to bannerLeft > -------------------------------------------------------- > > Key: MSKINS-170 > URL: https://issues.apache.org/jira/browse/MSKINS-170 > Project: Maven Skins > Issue Type: Improvement > Components: Fluido Skin > Affects Versions: fluido-1.9 > Reporter: Konrad Windszus > Priority: Major > > Currently there is a fallback with text in case no bannerLeft is configured: > https://github.com/apache/maven-fluido-skin/blob/f966972c504c8a01a5d7a203de6438464877a8bd/src/main/resources/META-INF/maven/site.vm#L188. > It would be nice to optionally show that next to the banner. -- This message was sent by Atlassian Jira (v8.20.7#820007)
