[
https://issues.apache.org/jira/browse/MSKINS-170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17533342#comment-17533342
]
Michael Osipov edited comment on MSKINS-170 at 5/7/22 9:14 PM:
---------------------------------------------------------------
Looking at the banner definition, it does not define whether both are exclusive
or. Moreover, I'd even say that it is incorrectly implemented in Fluido, href
refers to the image, but Fluido even links the banner name. The a element
somewhat duplicates the alt/title attribute.
Back to the problem: How do you expect this to be?
{noformat}
{img} {name}, {name} {img}, {name}: {img}?
{noformat}
The options are endless...
was (Author: michael-o):
Looking at the banner definition, it does not define whether both are exclusive
or. Moreover, I'd even say that it is incorrectly implemented in Fluido, href
refers to the image, but Fluido even links the banner name. The a element
somewhat duplicates the alt/title attribute.
Back to the problem: How do you expect this to be? {img} {name}, {name} {img},
{name}: {img}? The options are endless...
> Allow to show name as headline in addition to bannerLeft
> --------------------------------------------------------
>
> Key: MSKINS-170
> URL: https://issues.apache.org/jira/browse/MSKINS-170
> Project: Maven Skins
> Issue Type: Improvement
> Components: Fluido Skin
> Affects Versions: fluido-1.9
> Reporter: Konrad Windszus
> Priority: Major
>
> Currently there is a fallback with text in case no bannerLeft is configured:
> https://github.com/apache/maven-fluido-skin/blob/f966972c504c8a01a5d7a203de6438464877a8bd/src/main/resources/META-INF/maven/site.vm#L188.
> It would be nice to optionally show that next to the banner.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
