cstamas commented on PR #55: URL: https://github.com/apache/maven-assembly-plugin/pull/55#issuecomment-1115805829
We could even bolt on some existing IT, I did full IT suite build w/ and w/o this PR, here is what I got: These are states AFTER full IT suite ran successfully: Local repo by ITs * had 4192 files (master) vs 3418 files (PR). * size was 106816 bytes (master) vs 85808 bytes (PR). * CONTAINS org.eclipse.tycho maven plugin (master) vs DOES NOT contain s it (PR) And I think we got our test as well: tycho. It is a build plugin (used by sisu among others), and for sure NONE of our IT projects depend on it. Full outputs for reference below. On master (without PR): ``` cstamas@Urnebes ~/Worx/apache-maven/maven-assembly-plugin (master)$ find target/local-repo/ -type f | wc -l 4192 cstamas@Urnebes ~/Worx/apache-maven/maven-assembly-plugin (master)$ du target/local-repo/ -s 106816 target/local-repo/ cstamas@Urnebes ~/Worx/apache-maven/maven-assembly-plugin (master)$ ll target/local-repo/org/eclipse/ total 20 drwxrwxr-x 5 cstamas cstamas 4096 máj 3 09:11 ./ drwxrwxr-x 24 cstamas cstamas 4096 máj 3 09:11 ../ drwxrwxr-x 7 cstamas cstamas 4096 máj 3 09:06 aether/ drwxrwxr-x 6 cstamas cstamas 4096 máj 3 09:06 sisu/ drwxrwxr-x 18 cstamas cstamas 4096 máj 3 09:11 tycho/ cstamas@Urnebes ~/Worx/apache-maven/maven-assembly-plugin (master)$ ``` On this PR: ``` cstamas@Urnebes ~/Worx/apache-maven/maven-assembly-plugin (do-not-download-whole-universe)$ find target/local-repo/ -type f | wc -l 3418 cstamas@Urnebes ~/Worx/apache-maven/maven-assembly-plugin (do-not-download-whole-universe)$ du target/local-repo/ -s 85808 target/local-repo/ cstamas@Urnebes ~/Worx/apache-maven/maven-assembly-plugin (do-not-download-whole-universe)$ ll target/local-repo/org/eclipse/ total 16 drwxrwxr-x 4 cstamas cstamas 4096 máj 3 08:58 ./ drwxrwxr-x 22 cstamas cstamas 4096 máj 3 09:02 ../ drwxrwxr-x 7 cstamas cstamas 4096 máj 3 08:58 aether/ drwxrwxr-x 6 cstamas cstamas 4096 máj 3 08:58 sisu/ cstamas@Urnebes ~/Worx/apache-maven/maven-assembly-plugin (do-not-download-whole-universe)$ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
