[GitHub] [maven-assembly-plugin] cstamas commented on a diff in pull request #55: [MASSEMBLY-956] Resolve only what is needed for final assembly

[GitBox]

cstamas commented on code in PR #55:
URL: 
https://github.com/apache/maven-assembly-plugin/pull/55#discussion_r866097262


##########
src/main/java/org/apache/maven/plugins/assembly/archive/task/AddDependencySetsTask.java:
##########
@@ -183,7 +185,12 @@ void addDependencySet( final DependencySet dependencySet, 
final Archiver archive
 
     private ProjectBuildingRequest getProjectBuildingRequest( 
AssemblerConfigurationSource configSource )
     {
-        return configSource.getMavenSession().getProjectBuildingRequest();
+        MavenSession mavenSession = configSource.getMavenSession();
+        return new DefaultProjectBuildingRequest()
+                .setRepositorySession( mavenSession.getRepositorySession() )
+                .setSystemProperties( mavenSession.getSystemProperties() )
+                .setUserProperties( mavenSession.getUserProperties() )
+                .setProcessPlugins( false );
     }

Review Comment:
   Reusing it with copy-ctor, as setter of processPlugins modifies the existing 
instance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org