cstamas commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1072251713
> Actually Skipper does not help with multi module project. Maven builds module one by one, this means Maven will call [collectDependencies](https://github.com/bfs-skip/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L166) one by one for each module, and thus the cache (Args.pool, not a static one) won't be reused among the resolution of multiple modules. This means if we can reuse Args.pool (make map static & concurrent safe [here](https://github.com/bfs-skip/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DataPool.java#L72)), it should be faster when building multiple modules. I would like to try that in near future, maybe after @ibabiankou's PR. RU sure about this? As pool is created out of session (`DataPool pool = new DataPool( session );`) and it uses `RepositoryCache` if present (and Maven sets it). Also, as I debugged build, the Args.pool _does reuse_ caches, and they get existing instances pre-populated with values from previous calls. So to me, the cases seems reused during session life span... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
