cstamas edited a comment on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1070591546
@caiwei-ebay @michael-o @ibabiankou @jebeaudet IMO, this PR is good to be merged, so let's merge it. I personally am not quite convinced about this (BFS + skipper), I'd need more tests, and would like to see how these "scale" as well (test on project with 100, 200, 400 modules and so on). So, once merged, I'd like to implement following changes: * add indirection to DefaultDependencyCollector component (move the class from this PR to BFDependencyCollector, resurrect the DF one from master as DFDependencyCollector component) * introduce some config like `aether.dependencyCollector.impl=dfs|bfs` to select collector implementation * change skipper config to `aether.dependencyCollecttor.bfs.skipper=true|false` I am aware there is still one incoming change (parallel POM download), and BFS is needed for it, but once it lands as well, we can prove (or prove the opposite) and just drop the simple "indirection". But while not there, having both in maven will greatly simplify testing, and give possibility for users to change collection (even if we leave it in resolver upon release). For start, I plan just to "copy paste" the two collector components (one from here and one from master) that will most probably introduce quite some code duplication, but for now is fine. IF we decide to drop one, OR to keep both, we can clean up the duplication by refactoring (or just by dropping the one not needed anymore). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
