slawekjaranowski commented on a change in pull request #285:
URL: https://github.com/apache/maven/pull/285#discussion_r828974769
##########
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java
##########
@@ -39,14 +43,17 @@
private final Object mojo;
- private final ConfigurationListener delegate;
+ private final MojoDescriptor mojoDescriptor;
+
+ private final Logger logger;
Review comment:
It doesn't matter if we have plan add more cases for parameters.
Now I see three tasks:
- print values in debug logs
- check for required params
- check for deprecated params
I don't feel ok - with mixing three different responsibilities in one class
What name of class should be to show what class does?
But can be only my subjective opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
