slawekjaranowski commented on a change in pull request #285:
URL: https://github.com/apache/maven/pull/285#discussion_r828223482
##########
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java
##########
@@ -68,21 +75,31 @@
public void notifyFieldChangeUsingSetter( String fieldName, Object value,
Object target )
{
- delegate.notifyFieldChangeUsingSetter( fieldName, value, target );
+ if ( logger.isDebugEnabled() )
+ {
+ logger.debug( " (s) " + fieldName + " = " + toString( value ) );
+ }
if ( mojo == target )
{
notify( fieldName, value );
+
+ warnDeprecated( fieldName, value );
Review comment:
```
if ( logger.isWarnEnabled() ) ...
```
we needn't computation if we know that will not be logged finally
##########
File path:
maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java
##########
@@ -68,21 +75,31 @@
public void notifyFieldChangeUsingSetter( String fieldName, Object value,
Object target )
{
- delegate.notifyFieldChangeUsingSetter( fieldName, value, target );
+ if ( logger.isDebugEnabled() )
+ {
+ logger.debug( " (s) " + fieldName + " = " + toString( value ) );
+ }
Review comment:
We can use slf4j placeholders, here and in rest of logger calls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
