[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #469: [SUREFIRE-2011] Updated abstractions which helps associating standard out/err with a test

[GitBox]

Tibor17 commented on a change in pull request #469:
URL: https://github.com/apache/maven-surefire/pull/469#discussion_r806589916



##########
File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/output/ForkClient.java
##########
@@ -423,14 +424,14 @@ public final RunListener getReporter()
         return getTestSetReporter();
     }
 
-    public ConsoleOutputReceiver getConsoleOutputReceiver()
+    public TestOutputReceiver getConsoleOutputReceiver()
     {
-        return (ConsoleOutputReceiver) getTestSetReporter();
+        return getTestSetReporter();
     }
 
     private ConsoleLogger getOrCreateConsoleLogger()
     {
-        return (ConsoleLogger) getTestSetReporter();
+        return getTestSetReporter();
     }

Review comment:
       Because this PR has only limited refactoring. This PR is aming for 
refactoring of the interfaces of the listeners and the reason is the fact that 
we are not able to associate system output printed during the test without 
mapping the log message and test Thread. Other refactoring is out of the scope.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org