Tibor17 commented on a change in pull request #469:
URL: https://github.com/apache/maven-surefire/pull/469#discussion_r806577112
##########
File path: surefire-providers/surefire-junit47/pom.xml
##########
@@ -73,100 +79,6 @@
<propertyName>jacoco.agent</propertyName>
</configuration>
</plugin>
- <plugin>
- <artifactId>maven-dependency-plugin</artifactId>
- <executions>
- <execution>
- <id>main</id>
- <phase>process-sources</phase>
- <goals>
- <goal>unpack</goal>
- </goals>
- <configuration>
- <artifactItems>
- <artifactItem>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.7</version>
- <type>jar</type>
- <overWrite>true</overWrite>
-
<outputDirectory>${project.build.directory}/endorsed-tmp</outputDirectory>
- </artifactItem>
- </artifactItems>
- </configuration>
- </execution>
- <execution>
- <id>main-junit47-patch</id>
- <phase>process-sources</phase>
- <goals>
- <goal>unpack</goal>
- </goals>
- <configuration>
- <artifactItems>
- <artifactItem>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.12</version>
- <type>jar</type>
- <overWrite>true</overWrite>
-
<outputDirectory>${project.build.directory}/endorsed-tmp</outputDirectory>
-
<includes>org/junit/runner/notification/RunListener*</includes>
- </artifactItem>
- </artifactItems>
- </configuration>
- </execution>
- <execution>
- <id>test</id>
- <phase>process-test-sources</phase>
- <goals>
- <goal>copy</goal>
- </goals>
- <configuration>
-
<outputDirectory>${project.build.directory}/endorsed-test</outputDirectory>
- <overWriteIfNewer>false</overWriteIfNewer>
- <artifactItems>
- <artifactItem>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>4.12</version>
- <type>jar</type>
- </artifactItem>
- </artifactItems>
- </configuration>
- </execution>
- </executions>
- </plugin>
- <plugin>
- <artifactId>maven-assembly-plugin</artifactId>
- <executions>
- <execution>
- <id>patch-junit47</id>
- <phase>process-sources</phase>
- <goals>
- <goal>single</goal>
- </goals>
- <configuration>
- <attach>false</attach>
- <finalName>junit-4.7</finalName>
-
<outputDirectory>${project.build.directory}/endorsed</outputDirectory>
- <descriptors>
-
<descriptor>src/assembly/assembly.xml</descriptor>
- </descriptors>
- </configuration>
- </execution>
- </executions>
- </plugin>
- <plugin>
- <artifactId>maven-compiler-plugin</artifactId>
- <configuration>
- <compilerArguments>
-
<endorseddirs>${project.build.directory}/endorsed</endorseddirs>
- </compilerArguments>
- <testCompilerArguments>
-
<endorseddirs>${project.build.directory}/endorsed-test</endorseddirs>
- </testCompilerArguments>
- </configuration>
- </plugin>
<plugin>
Review comment:
Do you know the annotation `ThreadSafe` in JUnit4?
Threadsafe listeners.
This can be applied only on JUnit's `RunListener`. If it is done, the
JUnit's synchronization is avoided.
This annotation was used on the top of our `org.apache` listeners and so
this improvement was deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
